Runnable Embedded GlassFish improvements (stop on error, print message at the end) #25745
+124
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OndroMih
commented
Oct 22, 2025
OndroMih
commented
- stop automatically on error when executing commands
- print Welcome message at the beginning
- print message after shutdown, as the last message. Either OK message or error message.
dmatej
reviewed
Oct 22, 2025
| public void run() { | ||
| if (glassFish != null) { | ||
| stopGlassFish(); | ||
| // We restore the handlers because they are already removed from the logger in the shutdown hook |
There was a problem hiding this comment.
This is quite certainly bad idea, I will remember later why.
Btw logging should not be used for communication with the user, but we have this problem all over the sources. I already created an issue for that.
There was a problem hiding this comment.
This is not communication with the user, it’s a proper log message at the end. It can happen in Kubernetes for example, if the service is misconfigured.
what else do you suggest? System.err?
pzygielo
reviewed
Oct 22, 2025
nucleus/core/kernel/src/main/java/org/glassfish/runnablejar/UberMain.java
Outdated
Show resolved
Hide resolved
* stop automatically on error when executing commands * print Welcome message at the beginning * print message after shutdown, as the last message. Either OK message or error message.
OndroMih
force-pushed
the
ondromih-runnable-embedded-improvements
branch
from
6cb3e42 to
15d0fe1
Compare
pzygielo
reviewed
Oct 24, 2025
nucleus/core/kernel/src/main/java/org/glassfish/runnablejar/InfoPrinter.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.